yfxhust commented on a change in pull request #1235: ZOOKEEPER-3706:
ZooKeeper.close() would leak SendThread when the netw…
URL: https://github.com/apache/zookeeper/pull/1235#discussion_r374466290
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -782,6 +782,10 @@ void queueCallback(AsyncCallback cb, int rc, String path,
Object ctx) {
eventThread.queueCallback(cb, rc, path, ctx);
}
+ protected void onConnecting(InetSocketAddress addr) {
+ LOG.info("Try to connect to server {}.", addr);
Review comment:
Thanks your comments. Accept it. I will add comments to declare it as "test
only" and leave this method as empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
