yfxhust commented on a change in pull request #1235: ZOOKEEPER-3706:
ZooKeeper.close() would leak SendThread when the netw…
URL: https://github.com/apache/zookeeper/pull/1235#discussion_r374471742
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -1121,6 +1125,9 @@ private void startConnect(InetSocketAddress addr) throws
IOException {
LOG.warn("Unexpected exception", e);
}
}
+ if (!state.isAlive()) {
Review comment:
synchronized(state) is still not safe. Maybe SendThread.close() and
SendThread.startConnect() synchronize on different objects because state is
mutable and can be changed between SendThread.close() and
SendThread.startConnect().
I prefer synchronized(this) guard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
