sushantmane commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r406980974
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
> Activating it here is redundant, and breaks when you also activate the
full-build profile.
Why one needs to activate both profiles simultaneously?
A separate fat jar profile allows creating a fatjar without having to build
zookeeper-client and some other unnecessary modules.
> Alternatively, if you want to build the fatjar without the contribs, I
recommend moving the fatjar to a module outside of the contribs, so that
activation doesn't conflict with the full-build profile.
This is a good idea.
@breed Should we merge zookeeper-contrib-fatjar and the zookeeper-it module?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
