ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r407011553
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
> Why one needs to activate both profiles simultaneously?
Because I want to build everything to test the complete build.
Even if you don't want to do this, and really do want these to be mutually
exclusive profiles, the build is broken without this change. You need
`full-build` to activate the `zookeeper-contrib` parent pom, which is a
dependency of the `zookeeper-contrib-fatjar`. But, you can't activate the
`fatjar` profile and the `full-build` profile without the changes I made,
because together, they try to activate the `zookeeper-contrib-fatjar` module
twice, which Maven won't allow.
There are many ways to solve this... I chose one possibility, but there are
others.... it depends on what combination of options you want to support.
Personally, I would advise a solution that minimizes the number of profiles:
standard build or full build (with contribs). Then, all you need to decide is
whether you want the fatjar to be included in the standard build or the
`full-build` profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
