ctubbsii commented on a change in pull request #1793:
URL: https://github.com/apache/zookeeper/pull/1793#discussion_r788365338
##########
File path: LICENSE.txt
##########
@@ -200,3 +200,209 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
Review comment:
You can put the entire text in there, but more importantly, you should
not include it in here, because you haven't bundled Logback into the source.
You should only include LICENSE/NOTICE information for things actually
distributing as a bundle. This means the LICENSE/NOTICE files can be different
between the source tarball (official release) and the distribution tarball (AKA
"convenience binary") that actually includes the logback jar bundled.
So, these are the wrong files to modify. I'm not familiar enough with the ZK
build to know how the convenience binaries are built, but there should be a
separate mechanism to bundle LICENSE/NOTICE files into the convenience binary
than these, which are for the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
