ctubbsii commented on a change in pull request #1793:
URL: https://github.com/apache/zookeeper/pull/1793#discussion_r789101068
##########
File path: zookeeper-server/pom.xml
##########
@@ -75,8 +75,12 @@
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
Review comment:
@anmolnar Yeah, it wasn't that way for log4j1, because log4j1 was used
at compile time. However, part of this is to complete the migration to
`slf4j-api` at compile time, so the runtime implementations can be chosen by
users. So, no actual implementation jar should need to be `compile` scoped
anymore. They can just be `runtime` (or `test` if it is needed to compile the
tests; `test` implies `runtime` as well). The main point is that they aren't
needed at `compile` time, because `slf4j-api` is used at compile time instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
