anmolnar commented on a change in pull request #1793:
URL: https://github.com/apache/zookeeper/pull/1793#discussion_r788497962
##########
File path: LICENSE.txt
##########
@@ -200,3 +200,209 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
Review comment:
My assumption was based on this guide:
https://infra.apache.org/licensing-howto.html
> You must customize LICENSE and NOTICE files according to the content of
the specific distribution they reside within. Do not add to LICENSE and NOTICE
dependencies which are not in the distribution. **Only bundled bits matter.**
Even though logback is not included in our source distribution, we also have
a convenience binary distribution with first-level dependencies included. But.
Jetty falls into this bucket too which also has EPL v1.0 license and we don't
include it in top-level files. So, I ended up reverting these files and add the
logback license only to the resource folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
