kezhuw commented on code in PR #1852:
URL: https://github.com/apache/zookeeper/pull/1852#discussion_r843376225
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java:
##########
@@ -43,38 +40,20 @@
private static final Logger LOG =
LoggerFactory.getLogger(FileTxnSnapLogMetricsTest.class);
- CountDownLatch allCreatedLatch;
-
- private class MockWatcher implements Watcher {
-
- @Override
- public void process(WatchedEvent e) {
- LOG.info("all nodes created");
- allCreatedLatch.countDown();
- }
-
- }
-
@Test
public void testFileTxnSnapLogMetrics() throws Exception {
- SyncRequestProcessor.setSnapCount(100);
+ // disable automatic snapshot taking to leave writes in txn log
+ SyncRequestProcessor.setSnapCount(Integer.MAX_VALUE);
Review Comment:
Not sure, but I think almost all tests run and should run in dedicated
jvm(aka. false `reuseForks` in `zookeeper-server` module). This test is not an
exception. Restoring a primitive value has no means in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
