kezhuw commented on PR #1852: URL: https://github.com/apache/zookeeper/pull/1852#issuecomment-1161553240
@symat I think you are right about what the test try to express. But the original test does not assert that "we have a snapshot"(aka. "cnt_snapshottime"). That is why this fix pass. I think we could utilize `ZKTestCase.waitFor` to wait a snapshot and `FileSnap.close` to logs more txns after snapshot paused. I will push a fixup commit soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
