Shawyeok commented on PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#issuecomment-1853233745
> The metrics queue size is 1M by default it can be tuned. 1M of queue size seems too large. We reduced the queue size from 1M to 100K, the max GC pause was reduced 78% and the GC counts was reduced 80% That's cool! However, in my opinion, tuning the configuration for this queue size could be quite challenging for users, especially if they don't understand the working principle of the queue. It's hard to define a good value for this parameter. What do you think? > Instead of completely silently dropping the rejected tasks, we can create a PrometheusRejectedExecutionHandler that logs a WARN if the queue is full to help tuning the queue size. When the queue is full, some data points will be discarded, which might lead to a bias in the monitoring results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
