li4wang commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1894509471
########## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ########## @@ -91,6 +91,11 @@ public class PrometheusMetricsProvider implements MetricsProvider { */ static final String WORKER_SHUTDOWN_TIMEOUT_MS = "workerShutdownTimeoutMs"; + /** + * The interval in seconds for Prometheus summary metrics rotation. Default value is 60. + */ + static final String PROMETHEUS_SUMMARY_ROTATE_SECONDS = "prometheusMetricsSummaryRotateSeconds"; Review Comment: Can you update Zookeeper admin doc to include the property? https://zookeeper.apache.org/doc/r3.9.3/zookeeperAdmin.html#Debug+Log+Cleanup+Logback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org