li4wang commented on code in PR #2086: URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1894509743
########## zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java: ########## @@ -77,12 +73,14 @@ public class PrometheusMetricsProvider implements MetricsProvider { * Default value is 1. * If the number is less than 1, the main thread will be used. */ + @Deprecated static final String NUM_WORKER_THREADS = "numWorkerThreads"; /** * The max queue size for Prometheus summary metrics reporting task. * Default value is 1000000. */ + @Deprecated Review Comment: Please update the admin doc for the deprecation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org