ctubbsii commented on code in PR #2180:
URL: https://github.com/apache/zookeeper/pull/2180#discussion_r1720812598
##########
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetCommand.java:
##########
@@ -38,10 +39,11 @@ public class SetCommand extends CliCommand {
static {
options.addOption("s", false, "stats");
options.addOption("v", true, "version");
+ options.addOption("b", false, "base64");
}
public SetCommand() {
- super("set", "[-s] [-v version] path data");
+ super("set", "[-s] [-v version] [-b] path data");
Review Comment:
No hex option here?
##########
zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetCommand.java:
##########
@@ -38,10 +37,12 @@ public class GetCommand extends CliCommand {
static {
options.addOption("s", false, "stats");
options.addOption("w", false, "watch");
+ options.addOption("b", false, "base64");
+ options.addOption("x", false, "hexdump");
}
public GetCommand() {
- super("get", "[-s] [-w] path");
+ super("get", "[-s] [-w] [-b] [-x] path");
Review Comment:
single character flags that have no description aren't very useful. -b64 and
-hex would be easier to immediately understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
