Shawyeok commented on code in PR #2180:
URL: https://github.com/apache/zookeeper/pull/2180#discussion_r1720942890


##########
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetCommand.java:
##########
@@ -38,10 +39,11 @@ public class SetCommand extends CliCommand {
     static {
         options.addOption("s", false, "stats");
         options.addOption("v", true, "version");
+        options.addOption("b", false, "base64");
     }
 
     public SetCommand() {
-        super("set", "[-s] [-v version] path data");
+        super("set", "[-s] [-v version] [-b] path data");

Review Comment:
   Yes, hexdump only provided to reading binary data, since it's output in 
multiline, it is not appropriate support directly in single line command here.
   
   Below is a hexdump output example:
   ```
   get -x /foo
            +-------------------------------------------------+
            |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
   +--------+-------------------------------------------------+----------------+
   |00000000| 7a 6f 6f 6b 65 65 70 65 72                      |zookeeper       |
   +--------+-------------------------------------------------+----------------+
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to