ctubbsii commented on PR #2180: URL: https://github.com/apache/zookeeper/pull/2180#issuecomment-2295812874
@Shawyeok wrote: > The reality is that the zkCli tool is more of an interactive CLI tool, not designed for pipe connections. I think you misunderstood me. I agree that zkCli is interactive and not suitable for pipes. I am not suggesting zkCli be used that way (which is why I avoided using "zkCli" in my example). My suggestion was to provide a simpler non-interactive tool that would make it unnecessary to modify zkCli at all and still support the same use cases. > Binary data is a first-class primitive in ZooKeeper. All the setData and getData methods exchange data via byte arrays, not text. Therefore, binary data should not be considered domain-specific serialization. That's fair. I believe this to be the strongest argument in favor of adding these features to zkCli - so it can handle ZK's basic data type. That said, it has always been limited to Strings before, and users have managed to make things work without binary data in zkCli. If the alternative tool I'm suggesting did exist, there probably wouldn't be a need to add it to zkCli. > In conclusion, what you aim for seems to require a brand new tool similar to `etcdctl`. I believe it is not appropriate to implement this in this small feature PR. I'm not familiar with `etcdctl` at all. The alternative I was suggesting would be small, too (maybe even smaller than this PR... the actual ZK code is only a line or two, so most of it would be just parsing the command-line options for the connection string and client config, and dealing with the STDIN/STDOUT streams). If these changes are added to zkCli, that's fine with me. I may still pursue the alternate suggestion in the future, though, because I think there'd still be room for such a tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
