anmolnar commented on PR #1917: URL: https://github.com/apache/zookeeper/pull/1917#issuecomment-2344640643
> I think the fix clould be as simple as droping `syncUninterruptibly` from `channel.close().syncUninterruptibly()`. This way we break the deadlock chain. @MikeEdgar @kezhuw Calling a sync method in an aync operation inside a lock is a code small I believe, so I tend to prefer this solution over what the patch suggests. Is this `sync` call was the root cause of the original lock contention? I mean did you see that the thread is waiting for this call in particular why cannot release the lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
