kezhuw commented on code in PR #1917:
URL: https://github.com/apache/zookeeper/pull/1917#discussion_r1766935909
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java:
##########
@@ -255,7 +255,7 @@ private void detectMode() throws IOException {
bytesRead = 0;
}
- if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus))) {
+ if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus), false)) {
Review Comment:
This variant is brand new in `netty-4.1.113.Final`, so this patch will
enforce netty version. Given my comments
https://github.com/apache/zookeeper/pull/1917#issuecomment-2345528254, I am +1
to this. So, client will have to bump its netty version to match this patch in
compilation.
netty commit:
https://github.com/netty/netty/commit/dc30c3337a766d9f9519e910438ed3a3ae1b3761#diff-963dd9b8e77e913395273812889e9b6f2f449fe55e2b748b95311b219d1c58faR1286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
