anmolnar commented on code in PR #1917:
URL: https://github.com/apache/zookeeper/pull/1917#discussion_r1767074749
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java:
##########
@@ -255,7 +255,7 @@ private void detectMode() throws IOException {
bytesRead = 0;
}
- if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus))) {
+ if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus), false)) {
Review Comment:
Isn't that a problem if we backport this to 3.9? (I want to)
Can we just use another variant which is backward compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
