MikeEdgar commented on code in PR #1917:
URL: https://github.com/apache/zookeeper/pull/1917#discussion_r1767094883
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java:
##########
@@ -255,7 +255,7 @@ private void detectMode() throws IOException {
bytesRead = 0;
}
- if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus))) {
+ if (bytesRead == litmus.length &&
SslHandler.isEncrypted(Unpooled.wrappedBuffer(litmus), false)) {
Review Comment:
The only other variant is the deprecated one, which fails to compile due to
the `-Werror` flag. This file change could possibly be left out of a backport
which uses an older netty version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
