anmolnar commented on PR #2176: URL: https://github.com/apache/zookeeper/pull/2176#issuecomment-2364629073
> > Excellent candidate for 3.9.3 release. Thanks! > > Question: why have you moved logic out of the class to static class `SecurityUtils` while you're not using it anywhere else. For instance `getAppConfigurationEntryWithSection()` is only used in `SaslQuorumAuthServer`, so it should be a private method of it. > > getAppConfigurationEntryWithSection is also used in SecurityUtils‘s other methods. SecurityUtils::getDigestMd5Credentials -> SecurityUtils::getServerAppConfigurationEntry -> SecurityUtils::getAppConfigurationEntryWithSection. Following the call chain it still seems to me that every method is used only in `ServerCnxnFactory` abstract class, but correct me if I'm wrong. All of these methods should belong to there. You can still make them visible for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
