luoxiner commented on PR #2176:
URL: https://github.com/apache/zookeeper/pull/2176#issuecomment-2365437556
Hi, @kezhuw @anmolnar I make some changes.
1. remove `getAppConfigurationEntryWithSection` and
`getServerAppConfigurationEntry` in `SecurityUtils` because the caller alreay
have an `AppConfigurationEntry[]` entries in the context, we can use it
directly, we don’t need check and get again in the Utils methods.
Codes here:
[[ServerCnxnFactory](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java#L243)](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java#L243)
[[SaslQuorumAuthServer](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java#L52)](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java#L52)
2. move getServerCredentials to ServerCnxnFactory and make it private.
Please take a look and give some feed back, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
