Re: [PR] ZOOKEEPER-4839: Fix SASL DIGEST-MD5 authenticated with last successfully logined username [zookeeper]

[via GitHub]

luoxiner commented on PR #2176:
URL: https://github.com/apache/zookeeper/pull/2176#issuecomment-2365007130

   Hi, @kezhuw @anmolnar  I find something confused me.
   
   
[[SaslQuorumServerCallbackHandler](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java#L82)](https://github.com/apache/zookeeper/blob/bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/SaslQuorumServerCallbackHandler.java#L82)
   
   The codes here are correct ?
   
   I think if a section contains a module that is DigestLoginModule, we can set 
isDigestAuthn to true.
   
   So i think the correct codes are
   
   ```java
   boolean isDigestAuthn = false;
   for (AppConfigurationEntry entry : configurationEntries) {
                if 
(entry.getLoginModuleName().equals(DigestLoginModule.class.getName())) {
         Map<String, ?> options = entry.getOptions();
         // Populate DIGEST-MD5 user -> password map with JAAS configuration 
entries from the "QuorumServer" section.
         // Usernames are distinguished from other options by prefixing the 
username with a "user_" prefix.
         for (Map.Entry<String, ?> pair : options.entrySet()) {
             String key = pair.getKey();
             if (key.startsWith(USER_PREFIX)) {
                 String userName = key.substring(USER_PREFIX.length());
                 credentials.put(userName, (String) pair.getValue());
             }
         }
         isDigestAuthn = true;
      }
   }
   ```
   
    Am I right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org