Shawyeok commented on code in PR #2086:
URL: https://github.com/apache/zookeeper/pull/2086#discussion_r1896616814
##########
zookeeper-metrics-providers/zookeeper-prometheus-metrics/pom.xml:
##########
@@ -33,6 +33,7 @@
<properties>
<prometheus.version>0.9.0</prometheus.version>
+ <datasketches.version>4.2.0</datasketches.version>
Review Comment:
@li4wang
I conducted a benchmark for `Summary#observe` performance between versions
`0.16.0` and `1.3.5` (latest) of the Prometheus Java client library. The result
shows minimal improvement:
```
Benchmark (detailLevel) (version) Mode Cnt Score
Error Units
SummaryBenchmark.summaryObserve BASIC 1.x thrpt 3 1.027
± 0.446 ops/us
SummaryBenchmark.summaryObserve BASIC 0.x thrpt 3 1.041
± 0.843 ops/us
SummaryBenchmark.summaryObserve ADVANCED 1.x thrpt 3 1.009
± 0.671 ops/us
SummaryBenchmark.summaryObserve ADVANCED 0.x thrpt 3 0.967
± 0.979 ops/us
```
Full result:
https://gist.github.com/Shawyeok/4a7ef034baa187b27a9321145d2f05c9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
