On Fri, 2025-11-07 at 21:19 -0800, John Hubbard wrote:
> > 
> > Spec::try_from(boot0) will always fail, because we can't generate a Spec 
> > from a pre-Turing
> > GPU,
> > so it seems weird that we have it as an else condition.
> > 
> > I don't think the comment and the code aligns.  The code implies that 
> > sometimes we'll be
> > using
> > boot0 to generate the Spec, but that isn't true.  However, the comment 
> > makes it clear that
> > we'll
> > be using boot42 only.
> 
> Hmmm, yes, the new use_boot42_instead() logic means that most of the
> boot0 logic should actually be deleted now. OK, so I can apply this
> diff on top, and everything still works:

...

This is much better, thanks.

Reply via email to