On Sat, Dec 06, 2025 at 12:42:03PM +0000, Zhi Wang wrote:
> + /// Find the extended capability
> + pub fn find_ext_capability(&self, cap: i32) -> Option<u16> {
> + // SAFETY: `self.as_raw()` is a valid pointer to a `struct pci_dev`.
> + let offset = unsafe {
> bindings::pci_find_ext_capability(self.as_raw(), cap) };
> + if offset != 0 {
> + Some(offset as u16)
> + } else {
> + None
> + }
> + }
This is a good candidate to use `Option<NonZeroU16>` for the return
type as you don't expect Some(0) to be valid. It will also enable niche
optimisation for the Option. The whole if statement can even be replaced
by `NonZeroU16::new(offset as 16)` which return an option directly.
