Update of /export/home/ntop/ntop
In directory jabber:/tmp/cvs-serv15413
Modified Files:
address.c globals-core.h globals.h hash.c http.c initialize.c
netflow.c ntop.h pbuf.c protocols.c report.c reportUtils.c
sessions.c util.c webInterface.c
Log Message:
This is the "Great Debug Cleanup Patch" It does a bunch of things, all of which
are irrelevant to the normal paths and operation of ntop. So, what does it do?
1. It removes the (commented out) #define this_DEBUG and #define that_DEBUG
lines that have crept into the source.
2. All of the traceEvent debug lines now identify themselves in the log, e.g.
DNS-DEBUG: Fetched data ....
3. A couple of size/limit constants were pulled into globals.h
4. FREE_HOST_INFO was renamed HOST_FREE_DEBUG so it's more in keeping with the
other "DEBUG" names.
5. The (unused) routine dumpHash() was moved into hash.c from pbuf.c.
6. URL_LEN was changed to URL_MAX_LEN for better descriptiveness.
7. Dead but retained code in initialize.c and util.c was commented for future use.
8. All of the DEBUG #defines were consolidated into ntop.h with descriptive
comments and a warning message:
/*
* Debug settings...
*
* WARNING: Descriptions are APPROXIMATE. Check the code before turning
* these on/off. They can cause HUGE amounts of log messages,
* and/or slow ntop down so it can't keep up.
*
* Debugging code has not been widely tested, is subject to change
* on a developers whim and should NOT be used on production systems!
*
* OK? You've been warned!
*
* If you add something here, remember to add it to the #ifdef and the
* detailed reporting lines in webInterface.c
*
* 1st are those normally defined.
* Comment these out to make MAJOR, debug-type changes in ntop's activities!
* 2nd are those normally NOT defined.
* Enable these out to make MAJOR, debug-type changes in ntop's activities!
* These are usually lots and lots of log messages
* 3rd are those that cause more data (perhaps controversial or experimental) to
* be reported.
*/
9. PRINT_ALL_ACTIVE_SESSIONS changed to PRINT_ALL_SESSIONS because that's what it does.
10. More stuff added to info.html and textinfo.html, most only in textinfo.html.
However,
if ANY of the DEBUGs are defined, the whole bunch of them are reported in info.html
11. One dead definition that was missed before, updateHostsDeviceThpt() is removed
from the extern declarations.
-----Burton (Ref: BMS-0087)
_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://lists.ntop.org/mailman/listinfo/ntop-dev
