On Sat, Jun 16, 2012 at 9:39 PM, Nathaniel Smith <[email protected]> wrote:
> On Thu, Jun 14, 2012 at 5:20 PM, David Cournapeau <[email protected]> > wrote: > > > > > > On Thu, Jun 14, 2012 at 5:17 PM, Nathaniel Smith <[email protected]> wrote: > >> > >> On Wed, Jun 6, 2012 at 11:08 PM, Nathaniel Smith <[email protected]> wrote: > >> > Just submitted this pull request for discussion: > >> > https://github.com/numpy/numpy/pull/297 > >> > > >> > As per earlier discussion on the list, this PR attempts to remove > >> > exactly and only the maskna-related code from numpy mainline: > >> > > http://mail.scipy.org/pipermail/numpy-discussion/2012-May/062417.html > >> > > >> > The suggestion is that we merge this to master for the 1.7 release, > >> > and immediately "git revert" it on a branch so that it can be modified > >> > further without blocking the release. > >> > > >> > The first patch does the actual maskna removal; the second and third > >> > rearrange things so that PyArray_ReduceWrapper does not end up in the > >> > public API, for reasons described therein. > >> > > >> > All tests pass with Python 2.4, 2.5, 2.6, 2.7, 3.1, 3.2 on 64-bit > >> > Ubuntu. The docs also appear to build. Before I re-based this I also > >> > tested against Scipy, matplotlib, and pandas, and all were fine. > >> > >> While it's tempting to think that the lack of response to this > >> email/PR indicates that everyone now agrees with me about how to > >> proceed with the NA work, I'm for some reason unconvinced... > >> > >> Any objections to merging this? > > > > > > No objection, but could you wait for this WE ? I am in the middle of > setting > > up a buildbot for windows for numpy (for both mingw and MSVC compilers), > and > > that would be a good way to test it. > > Sounds like we have consensus and the patch is good to go, so let me > know when you're ready... > Setting up the windows builbot is even more of a pain than I expected :( In the end, I just tested your branch with MSVC for python 2.7 (32 bits), and got the following errors related to NA: ====================================================================== ERROR: test_numeric.TestIsclose.test_masked_arrays ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\Python27\lib\site-packages\nose-1.1.2-py2.7.egg\nose\case.py", line 197, in runTest self.test(*self.arg) File "C:\Users\david\tmp\numpy-git\numpy\core\tests\test_numeric.py", line 1274, in test_masked_arrays assert_(type(x) == type(isclose(inf, x))) File "C:\Users\david\tmp\numpy-git\numpy\core\numeric.py", line 2073, in isclose cond[~finite] = (x[~finite] == y[~finite]) File "C:\Users\david\tmp\numpy-git\numpy\ma\core.py", line 3579, in __eq__ check = ndarray.__eq__(self.filled(0), odata).view(type(self)) AttributeError: 'NotImplementedType' object has no attribute 'view' ====================================================================== ERROR: Test a special case for var ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\Users\david\tmp\numpy-git\numpy\ma\tests\test_core.py", line 2735, in test_varstd_specialcases _ = method(out=nout) File "C:\Users\david\tmp\numpy-git\numpy\ma\core.py", line 4778, in std dvar = sqrt(dvar) File "C:\Users\david\tmp\numpy-git\numpy\ma\core.py", line 849, in __call__ m |= self.domain(d) File "C:\Users\david\tmp\numpy-git\numpy\ma\core.py", line 801, in __call__ return umath.less(x, self.critical_value) RuntimeWarning: invalid value encountered in less David
_______________________________________________ NumPy-Discussion mailing list [email protected] http://mail.scipy.org/mailman/listinfo/numpy-discussion
