Citeren Charles Lepple <[email protected]>:

Well, the only thing we could do, is fallback to these defaults if the detection via 'libusb-config' fails to detect the libusb presence.
Just saw that patch. Should we check for "usb.h" (the 0.1 API) instead of "libusb.h"?

You're absolutely right, this was a mistake. I committed a change to check for the proper header. Note that I feel we should only do this when falling back to the build in defaults, therefor if 'libusb-config' is available, we don't check.

If 'libusb-config' gives us the wrong info (and despite setting the CFLAGS and LDFLAGS according to its results these functions are not available), I think this should result in a compiler/linker error (and that we shouldn't just silently disable USB support).

Best regards, Arjen
--
Please keep list traffic on the list


_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev

Reply via email to