On Thu, Sep 9, 2021 at 2:05 PM Ben Widawsky <[email protected]> wrote: [..] > > Caching is totally fine, I was just suggesting keeping the side effects out of > the innocuous sounding cxl_mem_get_partition_info(). I think I originally > authored authored cxl_mem_identify(), so mea culpa. I just realized it after > seeing the removal that I liked Ira's functional style. > > Perhaps simply renaming these functions is the right solution (ie. save it > for a > rainy day). Populate is not my favorite verb, but as an example: > static int cxl_mem_populate_partition_info > static int cxl_mem_populate_indentify
Sure, I would not say "no" to a follow-on cleanup patch along those lines that brought these two functions into a coherent style.
