On Mon, Sep 13, 2021 at 3:20 PM Dan Williams <[email protected]> wrote: > > Commit 0b9159d0ff21 ("cxl/pci: Store memory capacity values") missed > updating the kernel-doc for 'struct cxl_mem' leading to the following > warnings: > > ./scripts/kernel-doc -v drivers/cxl/cxlmem.h 2>&1 | grep warn > drivers/cxl/cxlmem.h:107: warning: Function parameter or member 'total_bytes' > not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'volatile_only_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'persistent_only_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'partition_align_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'active_volatile_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'active_persistent_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'next_volatile_bytes' not described in 'cxl_mem' > drivers/cxl/cxlmem.h:107: warning: Function parameter or member > 'next_persistent_bytes' not described in 'cxl_mem' > > Also, it is redundant to describe those same parameters in the > kernel-doc for cxl_mem_get_partition_info(). Given the only user of that > routine updates the values in @cxlm, just do that implicitly internal to > the helper. > > Cc: Ira Weiny <[email protected]> > Reported-by: Ben Widawsky <[email protected]> > Reviewed-by: Jonathan Cameron <[email protected]> > Signed-off-by: Dan Williams <[email protected]> > --- > Changes since v4: > - Update the kdoc for @partition_align_bytes (Ben) > - Collect Jonathan's reviewed-by pending above update.
Ugh, nope, still had this change in my working tree. v6 inbound.
