On 28.11.22 20:50:16, Robert Richter wrote: > On 24.11.22 10:35:27, Dan Williams wrote: > > In preparation for devm_cxl_add_endpoint() to call out to > > cxl_rcrb_to_component() to map the upstream port component registers, > > move devm_cxl_add_endpoint() from the cxl_core to the cxl_mem driver. > > This is due to the organization of cxl_test that mandates that the > > cxl_core not call out to any mocked symbols. It also cleans up the > > export of devm_cxl_add_endpoint() which is just a wrapper around > > devm_cxl_add_port(). > > The last sentense is unclear to me? I see you just make it static as > there is only a single user, do you mean that here? The change itself > looks good.
Looking at the next patch I think you mean the change of the function i/f of devm_cxl_add_endpoint() here. Please update description. > > > > > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> > > Reviewed-by: Robert Richter <rrich...@amd.com> > > > --- > > drivers/cxl/core/core.h | 8 -------- > > drivers/cxl/core/port.c | 39 --------------------------------------- > > drivers/cxl/cxl.h | 2 -- > > drivers/cxl/cxlmem.h | 9 +++++++++ > > drivers/cxl/mem.c | 38 ++++++++++++++++++++++++++++++++++++++ > > 5 files changed, 47 insertions(+), 49 deletions(-)
