Michael Hunter wrote: > A webrev for the rest of my changes due to codereview comments is at > /net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev > > I'm sending this out sans a complete rundown of disposition of all of > the comments. I'd like to this code back into the tree before I leave > for a long weekend. Hopefully before, but likely after that I'll work > with my reviewers over any issues. I've accepted without disagreement > the vast majority of the comments made so I don't expect any real > issues. > > Please review. > > ncu.c: I don't think you can _fini() an object before unlocking it - the _fini() action frees it, so the object mutex has gone away. You've got to _fini() then unlock.
libnwam.h: nit: since we're changing link_state to be a boolean, should we change the field name to "link_up" or "link_is_up"? (note that these changes will require a flag day to nwam-dev). otherwise looks good. Alan
