On Thu, 17 Sep 2009 16:33:22 +0100
Alan Maguire <Alan.Maguire at Sun.COM> wrote:
> Michael Hunter wrote:
> > A webrev for the rest of my changes due to codereview comments is at
> > /net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev
> >
> > I'm sending this out sans a complete rundown of disposition of all of
> > the comments. I'd like to this code back into the tree before I leave
> > for a long weekend. Hopefully before, but likely after that I'll work
> > with my reviewers over any issues. I've accepted without disagreement
> > the vast majority of the comments made so I don't expect any real
> > issues.
> >
> > Please review.
> >
> >
> ncu.c: I don't think you can _fini() an object
> before unlocking it - the _fini() action frees
> it, so the object mutex has gone away. You've
> got to _fini() then unlock.
Okay. I'll remove this and figure it out next week (I'm on vacation
Friday and Monday) 'cuz I want these changes to go back before I
leave. That leaves seb-092, seb-105, and responding to our reviewers
for all the ones I've fixed for me.
>
> libnwam.h: nit: since we're changing link_state
> to be a boolean, should we change the field
> name to "link_up" or "link_is_up"? (note that
> these changes will require a flag day to
> nwam-dev).
You and Renee have had the same comment so I'll change it to link_up.
mph
>
> otherwise looks good.
>
> Alan
