On Thu, 17 Sep 2009 09:34:06 -0400
Sebastien Roy <Sebastien.Roy at Sun.COM> wrote:
>
> On Thu, 2009-09-17 at 09:42 +0100, Alan Maguire wrote:
> > Michael Hunter wrote:
> > > A webrev for the rest of my changes due to codereview comments is at
> > > /net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev
> > >
> > > I'm sending this out sans a complete rundown of disposition of all of
> > > the comments. I'd like to this code back into the tree before I leave
> > > for a long weekend. Hopefully before, but likely after that I'll work
> > > with my reviewers over any issues. I've accepted without disagreement
> > > the vast majority of the comments made so I don't expect any real
> > > issues.
> > >
> > > Please review.
> > >
> > >
> > I'll take a look. One question - is this is all of the nwamd
> > comments marked as BUG on the wiki? Thanks!
>
> AFAIK, none of my code-review comments on nwamd have been addressed yet.
> At least, no-one has gotten back to me with any responses yet (did I
> miss them?).
I've addressed all but one of your CR comments that I've been assigned
with previous and this push. Given the period of time over which this
has taken it is going to take me a few hours to get things written up.
mph
>
> -Seb
>
>
