Sebastien Roy wrote: > On Fri, 2009-10-09 at 11:44 -0400, Anurag S. Maskey wrote: > >> changing permissions and group of flowadm.conf and flowprop.conf >> >> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >> > ... > >> Also, dlmgmtd needs to be run as netadm group, so it can create files >> and directories as dladm:netadm. These changes are included. >> > > Part of the dlmgmtd changes are problematic. There was a conscious > design decision made initially to not do name service lookups to lookup > user IDs and group IDs, as some misconfiguration of name services could > then result in a total breakdown of the system's networking > configuration. This is why a constant was introduced to represent > UID_DLADM in <sys/param.h>. You should do the same for the group ID and > introduce GID_NETADM. > I added UID_NETADM and GID_NETADM to sys/param.h and used these in dlmgmtd.
> On a related note, I don't know if you have a similar problem/bug in the > NWAM-related daemons. They shouldn't be doing any name-service lookups > to lookup user-IDs or group-IDs. > Good call. nwamd and netcfgd (in libnwam_backend.c:nwam_backend_init()) were doing name-service lookups. I replaced these with constants. The webrev has been updated with these changes. Anurag > -Seb > > >
