Sebastien Roy wrote: >>>>>>>>> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >>>>>>>>> >>>>>>>>> > Style nit: On line 201, continuation lines should be indented by 4 > spaces. Otherwise, looks good. > tab felt better earlier, but I've fixed this.
It appears that more work needed to be done to maintain the ownership and permission of the /etc/dladm/* files. * libdladm.c, libdlflow.c and secobj.c in usr/src/lib/libdladm/common/ needed to be cleaned up to create temp files with dladm:netadm ownership as well as the correct permissions. These temporary files overwrite the existing file when the new configuration is written out. * Also, no code uses GID_SYS anymore, so I've removed that constant from sys/param.h. I can keep it defined if desired. I apologize for not thoroughly testing everything earlier. The webrev has changes in lib/libdladm and sys/param.h that's different from what's already been reviewed. Thanks, Anurag
