On Mon, 2009-10-12 at 15:23 -0400, Sebastien Roy wrote: > On Mon, 2009-10-12 at 15:20 -0400, Anurag S. Maskey wrote: > > Sebastien Roy wrote: > > > On Mon, 2009-10-12 at 15:05 -0400, Anurag S. Maskey wrote: > > > > > >> Sebastien Roy wrote: > > >> > > >>> On Fri, 2009-10-09 at 11:44 -0400, Anurag S. Maskey wrote: > > >>> > > >>> > > >>>> changing permissions and group of flowadm.conf and flowprop.conf > > >>>> > > >>>> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ > > >>>> > > > One more comment: > > > > > > usr/src/pkgdefs/SUNWcnetr/postinstall > > > > > > * You have a for loop with a single constant argument... You don't need > > > a loop for that. > > > > > Thanks Seb. I've removed the loop in the postinstall script. > > Why not simply add secobj.conf to DLADM_FILES? The existing for loop at > 202 will result in the right chgrp operation. > > This can also be cleaned up a little by implying that all DLADM_FILES > are relative to DLADM_PATH. For example: > > DLADM_PATH="${PKG_INSTALL_ROOT}/etc/dladm" > DLADM_FILES="datalink.conf flowadm.conf flowprop.conf secobj.conf" > for file in ${DLADM_FILES}; do > chgrp netadm ${DLADM_PATH}/$file > done > chmod 660 ${DLADM_PATH}/secobj.conf
Or better yet, leave DLADM_FILES with absolute paths and simply call chgrp with the list of files on the command-line instead of using a loop: chgrp netadm $DLADM_FILES > > On a related note, how will this get done with IPS? -Seb
