On Mon, 30 Nov 2009 10:05:08 -0500 "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
> requesting code review for the following bugs: > > 9012 It's better if the output of 'nwamcfg list' and 'nwamadm list' > is not random sequence. > http://defect.opensolaris.org/bz/show_bug.cgi?id=9012 > > 11548 nwamcfg says lies about nothing to commit > http://defect.opensolaris.org/bz/show_bug.cgi?id=11548 > > 11987 nwamcfg should have a way to display all available properties > for an object > http://defect.opensolaris.org/bz/show_bug.cgi?id=11987 > > http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ > > Alan reviewed 11987 last week. The details of that RFE is in the > comment http://defect.opensolaris.org/bz/show_bug.cgi?id=11987#c1. I > also filed bug 12867 > (http://defect.opensolaris.org/bz/show_bug.cgi?id=12867) to update the > spec and manpages. nwamadm.c:848,nwamcfg.c:2988 Why create a variable which only holds this constant? libnwam.h:95,99 What does having NWAM_FLAG_WLAN_WALK_PRIORITY_ORDER and NWAM_FLAG_WALK_ALPHA_ORDER in the same flag set mean? libnwam_ncp.c:522-523 Would something break if you just always sorted the objects? Does anything assume some order in the walk? If not then why even have the flag? Just always sort. Michael > > Thanks, > Anurag > > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
