Michael Hunter wrote: >> requesting code review for the following bugs: >> >> 9012 It's better if the output of 'nwamcfg list' and 'nwamadm list' >> is not random sequence. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=9012 >> >> 11548 nwamcfg says lies about nothing to commit >> http://defect.opensolaris.org/bz/show_bug.cgi?id=11548 >> >> 11987 nwamcfg should have a way to display all available properties >> for an object >> http://defect.opensolaris.org/bz/show_bug.cgi?id=11987 >> >> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> >> Alan reviewed 11987 last week. The details of that RFE is in the >> comment http://defect.opensolaris.org/bz/show_bug.cgi?id=11987#c1. I >> also filed bug 12867 >> (http://defect.opensolaris.org/bz/show_bug.cgi?id=12867) to update the >> spec and manpages. >> > nwamadm.c:848,nwamcfg.c:2988 Why create a variable which only holds this > constant? > purely cosmetic. I didn't like "FLAG_1 | FLAG_2" wrapping two lines. I can use the actual flag rather than the variable if it is confusing.
> libnwam.h:95,99 What does having NWAM_FLAG_WLAN_WALK_PRIORITY_ORDER and > NWAM_FLAG_WALK_ALPHA_ORDER in the same flag set mean? > For Known WLANs, this should be an error. Only one of these walk flags should be used. For the other objects, nwam_valid_flags() will return failure if _WALK_PRIORITY_ORDER is given. I updated webrev for libnwam_known_wlan.c:nwam_walk_known_wlans() to make sure that only one of these flags is specified. > libnwam_ncp.c:522-523 Would something break if you just always sorted > the objects? Does anything assume some order in the walk? If not then > why even have the flag? Just always sort. > Nothing would break if the objects were always sorted. But they are not stored that way in the conf file and thus the flag to sort them. For ncp-*.conf files, the default order is as returned by readdir(3C). There is not always the need to do a sorted walk. For example, for "destroy -a" all objects are walked and it is not necessary to do a sorted walk. Anurag
