On Wed, 02 Dec 2009 15:32:47 -0500
"Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
> Michael Hunter wrote:
> >> You mean you prefer that the walk always be sorted without having to
> >> specify the flag or changing the order of objects in the files (which is
> >> contrary to Alan's preference in the bug comments)?
> >>
> >
> > I assume you mean this comment.
> >
> > alan>For me, the answer depends on whether we actually store things
> > alphabetically
> > alan>or not. If we fix libnwam so we do, I don't think a flag is needed. If
> > we
> > alan>don't, I think the flag is useful as a non-alphabetical walk would be
> > quicker.
> >
> yes
>
> > The first conditional (second sentence) doesn't apply to this code review.
> >
> > The third sentence makes the performance argument (which I thought
> > ya'all would bring up from the beginning). Given the length of this
> > list and the use of the API I don't think performance is a strong
> > enough reason to increase the complexity by an order of magnitude.
> >
> I didn't explicitly say performance,
No, but thats the core of Alan's argument that you referred to.
> but I did mention that keeping the
> objects sorted in the .conf files will make writes more complicated.
So don't.
[...]
Michael
