On Thu, Dec 03, 2009 at 01:03:11PM -0500, Anurag S. Maskey wrote: > > > Renee Danson Sommerfeld wrote: > >On Thu, Dec 03, 2009 at 10:19:08AM -0500, Anurag S. Maskey wrote: > >>>b) store the objects as-created, but always sort alphabetically when > >>> walking (except for wlans if priority order is requested); no flag > >>> needed. > >>webrev updated at > >>http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ > > > >Looks good; just one nit: the change in libnwam.h appears to be whitespace > >only; unless you fixed a cstyle bug there, better not to include that file > >(and definitely make sure you didn't introduce a cstyle bug!). > no, the change is fixing the spelling of "priority".
Wow, I scanned those lines looking for differences several times over, and managed to miss that every time. Glad you caught that. > Other files > have whitespaces added (that Michael mentioned), I'll remove them. I debated about commenting on the added whitespace in those files; in general, I would say not to make no-op changes like that if there aren't functional changes to the file as well. But in this case, I thought it looked a lot better with the extra line; and all the deltas will be collapsed before we go into ON, so the extra file mod will eventually go away. But it's not a big deal either way. -renee
