Alan Maguire wrote: > not sure if this is the up-to-date webrev but it looks > good to me. Nice use of qsort()! Thanks. webrev was updated about 10 minutes ago. If you saw NWAM_FLAG_WALK_ALPHA_ORDER (before the qsort()s), then it is old. The newer webrev just removed the flag and the conditional checks, so nothing major.
Anurag > > Alan > > Anurag S. Maskey wrote: >> requesting code review for the following bugs: >> >> 9012 It's better if the output of 'nwamcfg list' and 'nwamadm list' >> is not random sequence. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=9012 >> >> 11548 nwamcfg says lies about nothing to commit >> http://defect.opensolaris.org/bz/show_bug.cgi?id=11548 >> >> 11987 nwamcfg should have a way to display all available properties >> for an object >> http://defect.opensolaris.org/bz/show_bug.cgi?id=11987 >> >> http://zhadum.east/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> >> Alan reviewed 11987 last week. The details of that RFE is in the >> comment http://defect.opensolaris.org/bz/show_bug.cgi?id=11987#c1. I >> also filed bug 12867 >> (http://defect.opensolaris.org/bz/show_bug.cgi?id=12867) to update >> the spec and manpages. >> >> Thanks, >> Anurag >> >> _______________________________________________ >> nwam-dev mailing list >> nwam-dev at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/nwam-dev >
