Hi Julian,
Thanks for setting this up. I think this is of great value and we should take these warning very serious.
In case anyone wonders how to integrate this with IntelliJ: just enable the inspection called "Constants, conditions & exceptions". Took me a while to figure this out.
Michael On 18.5.12 11:16, Julian Reschke wrote:
Hi there, - oak-core and oak-jcr now include the necessary findbugs dependency (jsr305) - I have started annotating methods on JCR interface impls (SessionImpl & friends), plus a few internal classes (*Delegate) I believe this is useful, it already revealed a number of potential problems (see below). Adding the annotation *is* a bit verbose, but we can probably reduce the noise by adding class-wide (or even package-wide) defaults. Feedback appreciated, Julian -- snip -- Description Resource Path Location Type Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.PropertyDelegate.getPath() due to return value of called method PropertyDelegate.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr line 67 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.PropertyImpl.getParent() due to return value of called method PropertyImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr line 75 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$2.fetch() due to return value of called method QueryResultImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query line 140 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.query.RowImpl.getNodeForPath(String) due to return value of called method RowImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query line 60 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.security.user.UserManagerImpl.removeInternalProperty(Node, String) due to return value of called method UserManagerImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/security/user line 352 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.security.user.UserManagerImpl.setInternalProperty(Node, String, String, int) due to return value of called method UserManagerImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/security/user line 338 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.security.user.UserManagerImpl.setInternalProperty(Node, String, String[], int) due to return value of called method UserManagerImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/security/user line 343 FindBugs Problem (Troubling) Possible null pointer dereference in org.apache.jackrabbit.oak.jcr.security.user.UserManagerImpl.setInternalProperty(Node, String, Value[]) due to return value of called method UserManagerImpl.java /oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/security/user line 348 FindBugs Problem (Troubling)
