Jukka Zitting created OAK-148:
---------------------------------

             Summary: Drop feature checks from WorkspaceImpl
                 Key: OAK-148
                 URL: https://issues.apache.org/jira/browse/OAK-148
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: jcr
            Reporter: Jukka Zitting
            Priority: Minor


Many of the WorkspaceImpl methods use the ensureSupportedOption() method to 
check whether a particular repository descriptor is present. That's a bit 
backwards, as the presence of those descriptors should be based on the 
functionality available through the Workspace implementation, not the other way 
around.

Such checks make sense in cases like remoting layers where the features of the 
underlying implementation are unknown, but in a case like ours where we *do* 
know the underlying implementation so instead of inspecting the descriptors the 
WorkspaceImpl methods can either proceed directly to the implementation or just 
throw an UnsupportedRepositoryOperationException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to