[ 
https://issues.apache.org/jira/browse/OAK-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406436#comment-13406436
 ] 

Jukka Zitting commented on OAK-163:
-----------------------------------

bq. Hasn't been always reliable.

People are still expected to run the TCK before committing new stuff, so the CI 
build is just a failsafe for cases when that didn't happen. And if the CI build 
also fails to catch the problem, other committers will soon enough encounter 
the build failure. A test failure won't last long before being detected.

bq. Developer might not see it in time (end-of-day, vacation) or not paying 
attention.

We manage the codebase collectively, so anyone who sees a build failure is free 
to revert the commit that broke the build. Personally I much rather spend a few 
extra minutes reverting the occasional breaking change than having all my 
builds take longer.

I'd also be fine with a solution that I can selectively enable only on my 
machine to keep only fast tests in the default build, but I don't know a clean 
way of doing that. It's easier to selectively add bits to the build than to 
take them away.

See also OAK-53 where we already discussed the "long build" problem earlier.
                
> Move the JCR TCK back to the integrationTesting profile
> -------------------------------------------------------
>
>                 Key: OAK-163
>                 URL: https://issues.apache.org/jira/browse/OAK-163
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Jukka Zitting
>            Priority: Minor
>              Labels: tck
>         Attachments: 
> 0001-OAK-163-Move-the-JCR-TCK-back-to-the-integrationTest.patch
>
>
> In revision 1325811 the JCR TCK tests were moved from the integrationTesting 
> profile to a normal build. However, since then the execution time of the TCK 
> has grown to 3+ minutes, which is more than the rest of the Oak build 
> combined. To keep the build time down to at most a couple of minutes, I'd 
> like to move the TCK run back to the integrationTesting profile where it will 
> get executed only when explicitly requested (typically manually before a 
> commit or after one in a CI build).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to