[
https://issues.apache.org/jira/browse/OAK-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428049#comment-13428049
]
angela commented on OAK-232:
----------------------------
as far as i saw OAK-169 is rather about supported orderable child nodes in
general
while this specific one is about the hardcoded string which i didn't want to
hard code when fiddling around with the permissions. IMO it's much easier to
keep track of such a tmp and inconsistent solution if we avoid hard-coding it
it various places.
> Hardcoded "childOrder" in NodeDelegate
> --------------------------------------
>
> Key: OAK-232
> URL: https://issues.apache.org/jira/browse/OAK-232
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, jcr
> Reporter: angela
>
> there has been some discussion recently on how to deal with internal
> (hidden?) content
> such as for example the property reflecting the order of child nodes (see
> http://markmail.org/message/kzt7csiz2bd5n3ww).
> while working on some initial permission code i found that currently that
> property name
> is hardcoded in multiple places in NodeDelegate while at the same time the
> javadoc of
> NodeDelegate#getChildren refers to a different property name.
> until we reach consensus on how to deal with such internal content, if/how to
> hide it from
> JCR API consumers and whether or not (and to which extend) that should be a
> implementation
> detail of oak-core, i would suggest to define at least a constant on
> PropertyState that
> allows to easily identify and adjust all usages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
