[
https://issues.apache.org/jira/browse/OAK-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436829#comment-13436829
]
Michael Dürig commented on OAK-251:
-----------------------------------
I changed this in revision 1374342: now you pass the additional commit editor
the the merge method instead of to the branch method.
> CommitEditor is global to ContentRepository instance
> ----------------------------------------------------
>
> Key: OAK-251
> URL: https://issues.apache.org/jira/browse/OAK-251
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
>
> the CommitEditor (and thus the complete commit validation) is currently
> defined globally for the ContentRepository:
> public ContentRepositoryImpl(MicroKernel microKernel, QueryIndexProvider
> indexProvider,
> CommitEditor commitEditor) {
> nodeStore = new KernelNodeStore(microKernel);
> nodeStore.setEditor(commitEditor);
> while this might work for hardcoded editors/validators this doesn't work
> for those parts of the commit validation process that are depending on
> the content session (think of permission checks) or require a
> content session for execution (access to value factory, query engine etc.)
> if we want to adapt the validator concept for all kinds of commit
> validation this issue needs to be addressed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira