[ 
https://issues.apache.org/jira/browse/OAK-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443077#comment-13443077
 ] 

Michael Dürig commented on OAK-281:
-----------------------------------

Generally +1. However, wouldn't it be better to include {{startDiff()}} end 
{{endDiff()}} methods directly in {{NodeStateDiff}} instead of introducing 
{{NotificationNodeStateDiff}}? That way, {{RootImpl.getChangeExtractor()}} 
could directly call those methods. I think such methods could be helpful for 
the other use cases of {{NodeStateDiff}} as well. 
                
> Move ChangeProcessor to oak-core
> --------------------------------
>
>                 Key: OAK-281
>                 URL: https://issues.apache.org/jira/browse/OAK-281
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: Alex Parvulescu
>         Attachments: OAK-281.patch
>
>
> I'd like to move the ChangeProcessor to oak-core so other components (like 
> the IndexManager) can leverage the change observation mechanism

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to