[ 
https://issues.apache.org/jira/browse/OAK-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443218#comment-13443218
 ] 

Jukka Zitting commented on OAK-284:
-----------------------------------

+1 since the change is simple enough.

As a general rule I'd avoid complicating the code too much with optimizations 
like this until we have a better performance/scalability benchmark to validate 
the gains.

Note also that the internals of {{KernelNodeState}} will likely need to be 
refactored fairly heavily to address the TODO about references to child node 
states.
                
> Reduce memory usage of KernelNodeState
> --------------------------------------
>
>                 Key: OAK-284
>                 URL: https://issues.apache.org/jira/browse/OAK-284
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: OAK-284.patch
>
>
> The KernelNodeState keeps child nodes in a LinkedHashMap, which is used even 
> when there are no child nodes. The majority of nodes in a tree do not have 
> child nodes. I suggest to optimize this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to