[
https://issues.apache.org/jira/browse/OAK-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443918#comment-13443918
]
Michael Dürig commented on OAK-285:
-----------------------------------
bq. That's easy to control by managing the order of editors in a
CompositeEditor instance.
That's what I wanted to avoid as I have the feeling this might be too brittle.
Splitting it up in the way I proposed might not be fine grained enough though.
So I agree it is best to leave it as is until we have a better grasp on what we
actually need here.
bq. How about renaming CommitEditor to a more generic CommitHook instead?
+1
> Split CommitEditor into CommitEditor and Validator interfaces
> -------------------------------------------------------------
>
> Key: OAK-285
> URL: https://issues.apache.org/jira/browse/OAK-285
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Michael Dürig
>
> Having {{ValidatingEditor}} extend {{CommitEditor}} is a constant source of
> confusion since the former does not edit at all. Since it also makes sense to
> run validation only after all editing has taken place, I suggest to introduce
> a new interface {{CommitValidator}} which covers the validating aspect of a
> commit. Alternatively, we could of course also re-use the {{Observer}}
> interface here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
